External sort example #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
@lbwexler ... just doing some housekeeping of open issues / PRs. This PR adds an example of using |
|
yes!
…On Wed, Sep 8, 2021 at 5:40 AM Tom Tirapani ***@***.***> wrote:
@lbwexler <https://github.com/lbwexler> ... just doing some housekeeping
of open issues / PRs.
This PR adds an example of using GridModel.externalSort to Toolbox - is
it worth bringing it up to date and merging now that externalSort is no
longer experimental?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#380 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARTL2PNTTC2DZPHE4QGITDUA4VRDANCNFSM4LHGF7LQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
# Conflicts: # client-app/src/desktop/common/grid/SampleGridModel.js
|
Great - I've updated the example to work with the latest hoist-react and to be more consistent with the other examples in Toolbox |
|
@lbwexler I caught this branch up with latest, modernized it for typescript, etc - in the interests of cleaning up branches hopefully we can finally merge it :) |
Tweak placement of new example to be less prominent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.